-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Add default registry in kubevirt tilt file #12390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @johananl |
I can't reproduce this @Karthik-K-N. Can you specify your Tilt version, the commit you've used and your |
Sure, here it is
|
Looks like the error you're getting is because there is some problem with the wiring of the local container registry: Lines 43 to 46 in 4852b67
When I follow your instructions I do indeed get the error. Please try the following: make kind-cluster-kubevirt
make tilt-up Works for me. |
True that, but even with it I hit the issue. Even I can see the result
|
Not sure what should I do with this PR, should I close it? |
So you get an error from tilt even though you shouldn't because the ConfigMap exists? And it looks like not everyone is getting this issue? (I don't get it with regular I think I wouldn't change the documentation if we don't know why it only fails in some cases. Maybe you can do some further debugging of the kubectl command that is run to check if the ConfigMap exists. Maybe there's an error there |
/close Tried just now and able to see all the controllers are up, Not sure what was causing the issue earlier, Closing this. Sorry and Thank you. |
@Karthik-K-N: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Perfect. All good, no worries |
What this PR does / why we need it:
If we blindly follow the Developing Cluster API with Tilt in CAPI book for Kubevirt provider references and use the given tilt file content, we hit the following error
This PR would add the
default_registry
key into the tilt file.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #